Update the ResNet model for TensorFlow. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
reviewed
Dec 29, 2017
| @@ -117,6 +121,7 @@ def conv2d_fixed_padding(inputs, filters, kernel_size, strides, data_format): | |||
| """Strided 2-D convolution with explicit padding.""" | |||
| # The padding is consistent and is based only on `kernel_size`, not on the | |||
| # dimensions of `inputs` (as opposed to using `tf.layers.conv2d` alone). | |||
| # This is consistent with PaddlePaddle. | |||
There was a problem hiding this comment.
我觉这里可以tf计算output_size的代码贴上去，方便更好的了解这样做的原因 https://github.com/tensorflow/tensorflow/blob/f5f2f789ea395e585ddcbc43e088fa63d6b41d0e/tensorflow/core/framework/common_shape_fns.cc#L20
tensorflow/resnet.py
Outdated
| print( | ||
| "Pass = %d, Train performance = %f imgs/s, Test accuracy = %f\n" | ||
| % | ||
| (pass_id, num_samples / train_elapsed, np.mean(test_accs))) |
There was a problem hiding this comment.
test这一块写成一个函数是不是更合适些， for pass_id in range(args.pass_num):这个循环体显得很长
chengduoZH
approved these changes
Jan 4, 2018
|
LGTM++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28