Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive translate #2

Closed
RubensTen opened this issue Jul 4, 2018 · 3 comments
Closed

Responsive translate #2

RubensTen opened this issue Jul 4, 2018 · 3 comments

Comments

@RubensTen
Copy link

Hello, I found a issue when I resize the window or container of slide.

The scenarie is:

  • Load slide in the screen
  • After click in arrow right to traslate the current slide
  • Then resize the window or dimensions of container
  • Then you can see that the currrent value of translateX are not is valid, because the slide are not visible correctly

image

@DZuz14
Copy link
Owner

DZuz14 commented Jul 5, 2018

Yup you are totally right! Let me take a look into this!

@DZuz14
Copy link
Owner

DZuz14 commented Jul 6, 2018

So I feel that on window resize, we have to dynamically set the width of a slide to the size of the viewport. I havent had too much time to look into this, but do you have any suggestions?

In the css the .slide class is set to width of 100%, thats thats probably not going to fly on resize. Not sure though

@staywithme23
Copy link

@DZuz14 @RubensTen I sent a PR for this. #5

@DZuz14 DZuz14 closed this as completed Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants