fix: Add error to tags lookup if tag does not exist #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has been no error or check to determine if a tag exists already or not. This causes the terraform to always try to make a change if the tag does not exist, since there's no indication that the lookup didn't find anything. This is helpful, since it provides feedback to the user that the associated tag does not exist, and needs to be added with the `netbox_tag` resource. Since there are a lot of resources that use tags, we are only activating this feature on the netbox_virtual_machine resource to start. It can be added to other resources by returning the diag and appending it to the return of the function.
tagur87
force-pushed
the
virtual-machine-tags
branch
from
88bb1f5
to
e1eead9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been no error or check to determine if a tag exists already or not. This causes the terraform to always try to make a change if the tag does not exist, since there's no indication that the lookup didn't find anything.
This is helpful, since it provides feedback to the user that the associated tag does not exist, and needs to be added with the
netbox_tagresource.Since there are a lot of resources that use tags, we are only activating this feature on the netbox_virtual_machine resource to start. It can be added to other resources by returning the diag and appending it to the return of the function.