Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests!!! #10

Open
e-e-e opened this issue Dec 18, 2020 · 2 comments
Open

Add unit tests!!! #10

e-e-e opened this issue Dec 18, 2020 · 2 comments

Comments

@e-e-e
Copy link
Owner

e-e-e commented Dec 18, 2020

No description provided.

@raineorshine
Copy link
Collaborator

I had the same thought :).

What testing library do you prefer? I have experience with mocha and jest.

@e-e-e
Copy link
Owner Author

e-e-e commented Dec 19, 2020

I think either is fine, but prefer jest atm mostly for the simplicity it offers.

I was thinking unit tests, and also a daily smoke test. The Amazon service is fairly brittle as it parses html using puppeteer. it would be great to know when it breaks, so it can be fixed.

@e-e-e e-e-e mentioned this issue Dec 19, 2020
Merged
@e-e-e e-e-e changed the title Add tests!!! Add unit tests!!! Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raineorshine @e-e-e