Add option to pass hyperdb instance. #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-e-e
reviewed
Mar 24, 2018
| this.db = hyperdb(storage, key, opts) | ||
| opts = opts || {} | ||
| if (opts.db) { | ||
| this.db = opts.db |
There was a problem hiding this comment.
By having db as an opts variable, it makes the primary argument storage redundant. So perhaps we could achieve this instead by making storage itself optionally be a hyperdb instance. The question then is how to differentiate it from a storage function. Any thoughts?
Also Hello! I have been meaning to get in touch since returning to Australia.
|
You're right. I think we could check on Also hello back :-) I wanted to get in touch as well, still a little low on time but looking forward into collaboration here a lot. |
Merged
|
closing this as it will be merged with #11 |
|
this is now available from hyper-graph-db@0.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes hyper-graph-db usable with subhyperdb