Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/3.0.0 #116

Merged
merged 13 commits into from
Dec 23, 2019
Merged

Release/3.0.0 #116

merged 13 commits into from
Dec 23, 2019

Conversation

bvarner
Copy link
Contributor

@bvarner bvarner commented Dec 22, 2019

Due to breaking support of some past configuration options, as well as tooling version bumps, this is being marked as a major release.

  • Builds against Maven 3.6.0
  • Merged Fix #112 by removing artifact type/extension check #113 to fix Building master branch fails when artifact type and extension don't match #112
  • Cleaned up a lot of unnecessary code burden, standardized on defined repositories rather than the alt-syntax we had been using / supporting.
    • Repositories not present in the POM are not automatically setup for authn/z, mirroring, proxying, etc.
    • Repositories which used wagon extensions were inaccessible.
    • By leveraging the initial startup of maven with plexus, and then using those repositories and the built-in tooling to support those for aether dependency resolution, these issues were resolved.

bvarner and others added 13 commits May 9, 2019 11:46
…nsion as defined by the ArtifactHandler should always prevail.
* Bumping dependencies to Maven 3.6.0
* JDK 8

Guava was removed from Maven 3.6.0, and the older guava version had a few CVEs against it. So it was worth removing to cut dependencies.
…xt-check

Fix #112 by removing artifact type/extension check
Prepping for a 3.0 release with breaking changes to toolsets.
…y overdone for a few lines of utility methods that could live as privates in the Abstract mojo.
* Force all repositories to be referenced in the pom by id. Alternate syntax is causing issues with wagon transports and imposes an unnecessary code maintenance burden.
* Updated Documentation
    * ForkMode to forkCount.
    * Update examples for repositories
* Cleanup Maven Dependencies to exclude things pulled in and exposed by maven-core
* Cleaned up how remote repositories are created and resolved, so that we're always letting maven create the repository during the session creation.
    * MavenRepositorySession from the 'bridge' package is not exposed.
    * Repositories that come in as part of the pom / settings and are bootstrapped by plexus/maven get mirror, proxy, and authentication injection magically.
    * Constructing our own repositories doesn't get all that, and is overly complex and problematic.
    * Fixes Wagon Transport extensions added as plugin dependencies.
* Bumped to JDK 1.8
…failing

Feature/wagon transports failing
@coveralls
Copy link

Pull Request Test Coverage Report for Build 417

  • 44 of 46 (95.65%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 73.45%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/e_gineering/maven/gitflowhelper/AbstractGitflowBasedRepositoryMojo.java 42 44 95.45%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/e_gineering/maven/gitflowhelper/MasterPromoteExtension.java 1 96.15%
Totals Coverage Status
Change from base Build 398: 0.2%
Covered Lines: 545
Relevant Lines: 742

💛 - Coveralls

@bvarner bvarner merged commit e979095 into master Dec 23, 2019
@bvarner bvarner deleted the release/3.0.0 branch December 23, 2019 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building master branch fails when artifact type and extension don't match
3 participants