Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename UiModule to CviModule? #133

Open
certainlyakey opened this issue Jul 25, 2023 · 0 comments
Open

Rename UiModule to CviModule? #133

certainlyakey opened this issue Jul 25, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@certainlyakey
Copy link
Contributor

certainlyakey commented Jul 25, 2023

Summary

Right now the Angular implementation of the library exports UiModule to a consuming app. This name is too vague and unspecific, and in many consuming projects there might be already an UiModule of their own.

What alternatives have you tried?

A consuming application can rename an import with as keyword, but UiModule of CVI may be imported multiple times (for example, into each feature module and into an app's Storybook), and keeping up with the necessity to rename each import is tiresome. And as a third party dependency, CVI should prefix its exported members.

Does this feature request involve any updates to the reference design?

No

Implementation details

No response

@certainlyakey certainlyakey added the enhancement New feature or request label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant