Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Github Exploit for good output #407

Closed
jblu42 opened this issue Nov 24, 2022 · 8 comments
Closed

Filter Github Exploit for good output #407

jblu42 opened this issue Nov 24, 2022 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed issue in 3rd party component something in a 3rd party component we are using

Comments

@jblu42
Copy link
Contributor

jblu42 commented Nov 24, 2022

Is your feature request related to a problem? Please describe.
Currently when listing exploits in the F20 module a lot of exploits are listed from github that offer no value e.g. collections of vulnerability details that are direct copies from the CVE information, e.g.
https://github.com/thdusdl1219/CVE-Study
https://github.com/facebookincubator/nvdtools
https://github.com/akiraabe/myapp-container-jaxrs
https://github.com/rostskadat/ziniollc-devops-test-62f1178138d1
https://github.com/turbot/steampipe-plugin-trivy
It would be great to see on first view where PoCs are available

Describe the solution you'd like
As PoC can appear all over github, probably the best solution would be to blacklist some github pages in this module to allow a better overview

Any other ideas on that?

@m-1-k-3
Copy link
Member

m-1-k-3 commented Nov 24, 2022

Hi @jblu42

I'm aware that this feature is currently not ideal. We rely on the trickest collection (https://github.com/trickest/cve) for this feature. If there is some other repository with more accurate details let me know.

@m-1-k-3 m-1-k-3 added enhancement New feature or request help wanted Extra attention is needed issue in 3rd party component something in a 3rd party component we are using labels Nov 24, 2022
@jblu42
Copy link
Contributor Author

jblu42 commented Nov 24, 2022

@m-1-k-3 : It seems they have a blacklist. Does it make sense to propose these pages to their blacklist? I think it will probably get filtered out

@m-1-k-3
Copy link
Member

m-1-k-3 commented Nov 24, 2022

It would be worth a try.

@m-1-k-3
Copy link
Member

m-1-k-3 commented Nov 24, 2022

In the meantime we could include a blacklist in EMBA. Could you please create a PR with your blacklisted urls in config/trickest_blacklist.txt.
Then I will respect these URLs during building the data file.

@jlucius
Copy link
Contributor

jlucius commented Nov 26, 2022

Will you merge your changes first or shall I just do a PR with the blacklist file?

@m-1-k-3
Copy link
Member

m-1-k-3 commented Nov 26, 2022

As Benedikt has already approved the PR it is now merged.

@jlucius
Copy link
Contributor

jlucius commented Nov 28, 2022

I have also opened a pull request for trickest/cve, how would the format look like here in the emba blacklist? Is it the full path to github e.g. https://github.com/facebookincubator/nvdtools or just the repository e.g. facebookincubator/nvdtools?

I will test it within the next few days

@m-1-k-3
Copy link
Member

m-1-k-3 commented Nov 28, 2022

I did some initial tests with the complete repo name per entry line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed issue in 3rd party component something in a 3rd party component we are using
Projects
None yet
Development

No branches or pull requests

3 participants