Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to a callback/plugin architecture #12

Open
shankari opened this issue Mar 27, 2016 · 0 comments
Open

Move to a callback/plugin architecture #12

shankari opened this issue Mar 27, 2016 · 0 comments

Comments

@shankari
Copy link
Contributor

The current sync architecture interface is not clean.

  • On both android and iOS, it calls the usercache directly
  • On android, it calls the code to fix the state machine automatically, which is in the data-collection plugin.
  • On iOS, it is called from the data collection plugin since the sync happens in response to visit changes
  • On both, we read the battery level, which is a data collection thing, and uses the battery wrapper.

Need to do a good design and rework this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant