Implement runtime permissions #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also bump up the plugin number e-mission/e-mission-docs#325 (comment)
To address the change due to background limits in API 26. e-mission/e-mission-docs#325 (comment) e-mission/e-mission-docs#325 (comment)
In particular: - don't start tracking without consent - don't start tracking on reconfiguration before consent - simplify the checks in the plugin since that is not the single entry point anyway
Irrespective of any checks that we do earlier, we still need to handle exceptions from the actual methods in order to account for race conditions
+ modify location service prompts for greater consistency
since we don't receive the messages in API 26 anyway e-mission/e-mission-docs#325 (comment)
Broad idea of the updates e-mission/e-mission-docs#325 (comment) and e-mission/e-mission-docs#325 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes related to e-mission/e-mission-docs#325