Remove references to UIWebView #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched from including Bolts and Parse framework manually to including the Bolts/Tasks cocoapod. This: - allows us to avoid hard-copying source files - use only BFTasks and avoid imports through other parse modules (see BoltsFramework/Bolts-ObjC#331 This also allows us to remove additional frameworks from plugin.xml Yay!
shankari
added a commit
to shankari/cordova-server-sync
that referenced
this pull request
Apr 9, 2020
Since we don't really integrate with them anyway. This is related to e-mission/e-mission-data-collection@ebe2d20 in PR e-mission/e-mission-data-collection#184 Note that there appears to be a subtle bug here in which we save the sync config but don't update the profile. And we use the profile to determine the frequency at which to send the IOS pushes. But that is not really related to this change which attempted to save channels to a non-existent server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from including Bolts and Parse framework manually to including the Bolts/Tasks cocoapod.
This:
(see Apple Review BoltsFramework/Bolts-ObjC#331
This also allows us to remove additional frameworks from plugin.xml
Yay!