Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the UI devapp server to use the standard build scripts #18

Merged
merged 1 commit into from
Aug 7, 2021

Commits on Aug 7, 2021

  1. Change the UI devapp server to use the standard build scripts

    I originally wanted to put all the dependencies into the image instead of
    waiting until the container was set up. But different branches could have
    different dependencies and may not want to upgrade/downgrade. And putting this
    into the container allows us to use the standard build scripts and not have
    this bitrot.
    
    This file had
    ENV NODE_VERSION 9.4.0
    RUN npm install -g npm@6.0.0
    
    We are currently at
    
    export NODE_VERSION=14.7.0
    export NPM_VERSION=6.14.8
    
    using the standard scripts, which are regularly tested via CI, allows us to
    ensure that this dockerfile stays relevant across the many configurations that
    we currently support.
    
    This fixes e-mission/e-mission-docs#657
    shankari committed Aug 7, 2021
    Configuration menu
    Copy the full SHA
    7767773 View commit details
    Browse the repository at this point in the history