test image CI #24
Merged
test image CI #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made within examples/em-server-multi-tier-cronjob to use and run server images created by new CI in e-mission-server. CHANGEME left in docker-compose.yml for port number so that user/tester can think about what they need for their purposes themselves.
shankari
requested changes
Sep 22, 2022
There was a problem hiding this comment.
The biggest issue is around re-creating the conda environment at runtime.
You can also see this in the docker-compose output
em-server-multi-tier-cronjob-analysis-server-1 | About to start conda update, this may take some time...
em-server-multi-tier-cronjob-analysis-server-1 | Installing for version 4.8.3 and platform Linux-x86_64
em-server-multi-tier-cronjob-analysis-server-1 | % Total % Received % Xferd Average Speed Time Time Time Current
em-server-multi-tier-cronjob-analysis-server-1 | Dload Upload Total Spent Left Speed
em-server-multi-tier-cronjob-web-server-1 | About to start conda update, this may take some time...
em-server-multi-tier-cronjob-web-server-1 | Installing for version 4.8.3 and platform Linux-x86_64
em-server-multi-tier-cronjob-web-server-1 | % Total % Received % Xferd Average Speed Time Time Time Current
em-server-multi-tier-cronjob-web-server-1 | Dload Upload Total Spent Left Speed
Removed the use of a script that reinstalled conda while saving the config copying. Moved where supplemental scripts get copied into.
|
Changes made, committed. Runs without reinstalling conda, copies the config without another script, supplemental files are copied into |
shankari
reviewed
Sep 22, 2022
shankari
reviewed
Sep 22, 2022
Change starting image from one hosted by Andrew to Shankari. Tested and works.
shankari
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made within
examples/em-server-multi-tier-cronjobto use and run server images created by new CI ine-mission-server.CHANGEMEleft indocker-compose.ymlfor port number so that user/tester can think about what they need for their purposes themselves.Results of testing shown in e-mission/e-mission-server#875.
Requisite task to show feature e-mission/e-mission-docs#752 working.