Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Args in Compose to set Image #25

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Conversation

aGuttman
Copy link
Contributor

Adds args SERVER_IMAGE_TAG to webapp and analysis in the docker-compose. ARGs used in Dockerfiles of webapp and analysis to set server image to pull.

Tested. All containers run without problems. Redirects to NREL OpenPATH webpage as intended when connected to.

Adds SERVER_IMAGE_TAG to docker-compose of webapp and analysis. ARG gets used in the Dockerfiles of each to pull correct image.
Copy link
Contributor

@shankari shankari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also tested in the NREL In-house environment and on @aGuttman's laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants