-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✏️📖 Diary Services Rewrite #1085
✏️📖 Diary Services Rewrite #1085
Commits on Oct 26, 2023
-
Updated
diaryHelper.ts
, now uses luxondiaryHelper now only uses luxon, and does not rely on the momentjs library.
Configuration menu - View commit details
-
Copy full SHA for 6c23b2d - Browse repository at this point
Copy the full SHA 6c23b2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 062828e - Browse repository at this point
Copy the full SHA 062828eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ade8b7 - Browse repository at this point
Copy the full SHA 5ade8b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd05c89 - Browse repository at this point
Copy the full SHA dd05c89View commit details
Commits on Oct 30, 2023
-
Merge branch 'service_rewrite_2023' of https://github.com/e-mission/e…
…-mission-phone into diaryServices-rewrite Keeping code up to date, enable Prettier
Configuration menu - View commit details
-
Copy full SHA for 545d407 - Browse repository at this point
Copy the full SHA 545d407View commit details
Commits on Nov 2, 2023
-
Rewrote readUnprocessedTrips, helper functions
- moved functions to timelineHelper - updated momentJS code to luxon
Configuration menu - View commit details
-
Copy full SHA for 7a4b6fb - Browse repository at this point
Copy the full SHA 7a4b6fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5736a1 - Browse repository at this point
Copy the full SHA b5736a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd238e6 - Browse repository at this point
Copy the full SHA dd238e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e2022f - Browse repository at this point
Copy the full SHA 8e2022fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c7f4d8 - Browse repository at this point
Copy the full SHA 7c7f4d8View commit details
Commits on Nov 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 356dfcf - Browse repository at this point
Copy the full SHA 356dfcfView commit details
Commits on Nov 6, 2023
-
- Behavior remains unchanged when removing this component - labelTab and other parent components handle loading, so the ionic service is not needed.
Configuration menu - View commit details
-
Copy full SHA for 6dcf1ab - Browse repository at this point
Copy the full SHA 6dcf1abView commit details
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 651876b - Browse repository at this point
Copy the full SHA 651876bView commit details
Commits on Nov 8, 2023
-
Added basic timelineHelper tests
- Added test for each diaryService rewrite
Configuration menu - View commit details
-
Copy full SHA for 2bcdac8 - Browse repository at this point
Copy the full SHA 2bcdac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae5ae95 - Browse repository at this point
Copy the full SHA ae5ae95View commit details
Commits on Nov 9, 2023
-
Merge branch 'type_interfaces' into diaryServices-rewrite
Updated for changes
Configuration menu - View commit details
-
Copy full SHA for 1326940 - Browse repository at this point
Copy the full SHA 1326940View commit details -
Configuration menu - View commit details
-
Copy full SHA for efa96e0 - Browse repository at this point
Copy the full SHA efa96e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13206e9 - Browse repository at this point
Copy the full SHA 13206e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f031d33 - Browse repository at this point
Copy the full SHA f031d33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e1a402 - Browse repository at this point
Copy the full SHA 2e1a402View commit details -
Configuration menu - View commit details
-
Copy full SHA for adab677 - Browse repository at this point
Copy the full SHA adab677View commit details -
Expanded mocks, sured up tests
- borrowed the windowAlert mocks from PR e-mission#1093, to allow error checking - added mockCheck, updated some tests to use to `toEqual()`
Configuration menu - View commit details
-
Copy full SHA for 2d0d321 - Browse repository at this point
Copy the full SHA 2d0d321View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf91301 - Browse repository at this point
Copy the full SHA bf91301View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e1790e - Browse repository at this point
Copy the full SHA 7e1790eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b0e2d - Browse repository at this point
Copy the full SHA f4b0e2dView commit details
Commits on Nov 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for db8c7ad - Browse repository at this point
Copy the full SHA db8c7adView commit details -
Configuration menu - View commit details
-
Copy full SHA for a2426c4 - Browse repository at this point
Copy the full SHA a2426c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08c10f2 - Browse repository at this point
Copy the full SHA 08c10f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6a21ca - Browse repository at this point
Copy the full SHA e6a21caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e2e2a3 - Browse repository at this point
Copy the full SHA 2e2e2a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 361cc28 - Browse repository at this point
Copy the full SHA 361cc28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 570d7a7 - Browse repository at this point
Copy the full SHA 570d7a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 691aeb5 - Browse repository at this point
Copy the full SHA 691aeb5View commit details
Commits on Nov 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 84d675a - Browse repository at this point
Copy the full SHA 84d675aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 163dbb2 - Browse repository at this point
Copy the full SHA 163dbb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2b5da5 - Browse repository at this point
Copy the full SHA a2b5da5View commit details
Commits on Nov 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 20f5441 - Browse repository at this point
Copy the full SHA 20f5441View commit details
Commits on Nov 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 25a064d - Browse repository at this point
Copy the full SHA 25a064dView commit details -
Added npm package, fixed HTML formatting
- NPM package for GeoJSON types
Configuration menu - View commit details
-
Copy full SHA for fd0c1ab - Browse repository at this point
Copy the full SHA fd0c1abView commit details
Commits on Nov 21, 2023
-
Added localization for trip duration
- Changes utilize "humanize-duration" package
Configuration menu - View commit details
-
Copy full SHA for 9a20378 - Browse repository at this point
Copy the full SHA 9a20378View commit details -
Configuration menu - View commit details
-
Copy full SHA for d27cefe - Browse repository at this point
Copy the full SHA d27cefeView commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fe3d417 - Browse repository at this point
Copy the full SHA fe3d417View commit details -
Configuration menu - View commit details
-
Copy full SHA for 667fec8 - Browse repository at this point
Copy the full SHA 667fec8View commit details
Commits on Nov 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 07c5f80 - Browse repository at this point
Copy the full SHA 07c5f80View commit details
Commits on Nov 30, 2023
-
Added tests for updateUnprocessedInputs
- Added tests that utilize labelsPRomises - Cleaned up mocks, diaryTypes.
Configuration menu - View commit details
-
Copy full SHA for 0d1717d - Browse repository at this point
Copy the full SHA 0d1717dView commit details
Commits on Dec 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d93da07 - Browse repository at this point
Copy the full SHA d93da07View commit details
Commits on Dec 4, 2023
-
Update www/js/diary/diaryHelper.ts
Co-authored-by: Jack Greenlee <JackAGreenlee@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b59c65f - Browse repository at this point
Copy the full SHA b59c65fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92f4a64 - Browse repository at this point
Copy the full SHA 92f4a64View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3dc66f - Browse repository at this point
Copy the full SHA e3dc66fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d844466 - Browse repository at this point
Copy the full SHA d844466View commit details -
add getMessagesForInterval to BEMUserCache mock
This is much like getMessages, but also filters by time in addition to by key. Also modified both of these functions to support the `withMetadata` argument in mocks
Configuration menu - View commit details
-
Copy full SHA for c42665f - Browse repository at this point
Copy the full SHA c42665fView commit details -
add tests for updateLocalUnprocessedInputs
The stategy here is to use the mocked BEMUserCache to actually record some inputs (across both labels¬es and for trip&places), and then check that the new inputs show up in `unprocessedLabels` and `unprocessedNotes` after processing.
Configuration menu - View commit details
-
Copy full SHA for 650564a - Browse repository at this point
Copy the full SHA 650564aView commit details -
Merge branch 'diaryServices-rewrite' of https://github.com/the-bay-ka…
…y/e-mission-phone into diaryServices-rewrite
Configuration menu - View commit details
-
Copy full SHA for 1cb28c6 - Browse repository at this point
Copy the full SHA 1cb28c6View commit details -
Merge branch 'service_rewrite_2023' of https://github.com/e-mission/e…
…-mission-phone into diaryServices-rewrite
Configuration menu - View commit details
-
Copy full SHA for b6b7c94 - Browse repository at this point
Copy the full SHA b6b7c94View commit details -
A few properties duplicated while resolving merge conflicts
Configuration menu - View commit details
-
Copy full SHA for 356336c - Browse repository at this point
Copy the full SHA 356336cView commit details -
- made enketoHelper's filterByNameAndVersion accept appConfig as a parameter instead of retrieving it itself. This is 1) simpler, 2) doesn't have to be async anymore and 3) easier to test by swapping out configs Then, fixed the timelineHelper test by changing the mock config to have "TripConfirmSurvey" and the mock survey response to have the name "TripConfirmSurvey". Now it doesn't get filtered out and the test passes. Note that eventually we don't want this to be hardcoded, but it will require changes to the structure of the config and maybe a backwards-compat
Configuration menu - View commit details
-
Copy full SHA for f80deb9 - Browse repository at this point
Copy the full SHA f80deb9View commit details
Commits on Dec 6, 2023
-
- wrap the tests related to unprocessed inputs in a describe(...) - on the other mocks in this file, fallback to the original implementation - ensure both updateAllUnprocessedInputs and updateLocalUnprocessedInputs are used - tidy up the mock configs
Configuration menu - View commit details
-
Copy full SHA for 4d664ad - Browse repository at this point
Copy the full SHA 4d664adView commit details -
fix broken start time on draft trips
This was caused by missing parentheses - instead of passing the result of toISO(), we were passing the toISO function itself!
Configuration menu - View commit details
-
Copy full SHA for aa8cbe4 - Browse repository at this point
Copy the full SHA aa8cbe4View commit details
Commits on Jan 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dfbee1f - Browse repository at this point
Copy the full SHA dfbee1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fb7c95 - Browse repository at this point
Copy the full SHA 1fb7c95View commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e69138b - Browse repository at this point
Copy the full SHA e69138bView commit details
Commits on Jan 24, 2024
-
Update func param types, fix func formatting
- Expanded types for several function parameters - Changed exported functions of `() => {}` format to `function () {}`
Configuration menu - View commit details
-
Copy full SHA for a89f356 - Browse repository at this point
Copy the full SHA a89f356View commit details -
This better reflects the origin of this type: both BEMServerComm and BEMUserCache return data of this structure.
Configuration menu - View commit details
-
Copy full SHA for d54ce29 - Browse repository at this point
Copy the full SHA d54ce29View commit details
Commits on Jan 25, 2024
-
Imporved test in
timelineHelper.test.ts
Test now compares the unpacked object map to original object.
Configuration menu - View commit details
-
Copy full SHA for cdb7138 - Browse repository at this point
Copy the full SHA cdb7138View commit details -
Was running on `js/`, but not mocks; fixed formatting in mocks and tests!
Configuration menu - View commit details
-
Copy full SHA for 95d6255 - Browse repository at this point
Copy the full SHA 95d6255View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f73f74 - Browse repository at this point
Copy the full SHA 9f73f74View commit details -
Configuration menu - View commit details
-
Copy full SHA for f54257b - Browse repository at this point
Copy the full SHA f54257bView commit details