Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️📖 Diary Services Rewrite #1085

Merged

Commits on Oct 26, 2023

  1. Updated diaryHelper.ts, now uses luxon

    diaryHelper now only uses luxon, and does not rely on
    the momentjs library.
    the-bay-kay committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6c23b2d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    062828e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5ade8b7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dd05c89 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge branch 'service_rewrite_2023' of https://github.com/e-mission/e…

    …-mission-phone into diaryServices-rewrite
    
    Keeping code up to date, enable Prettier
    the-bay-kay committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    545d407 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Rewrote readUnprocessedTrips, helper functions

    - moved functions to timelineHelper
    - updated momentJS code to luxon
    the-bay-kay committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7a4b6fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b5736a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd238e6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8e2022f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7c7f4d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    356dfcf View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Removed $ionicLoading

    - Behavior remains unchanged when removing this component - labelTab
    and other parent components handle loading, so the ionic service is
    not needed.
    the-bay-kay committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    6dcf1ab View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    651876b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Added basic timelineHelper tests

    - Added test for each diaryService rewrite
    the-bay-kay committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    2bcdac8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ae5ae95 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Merge branch 'type_interfaces' into diaryServices-rewrite

    Updated for changes
    the-bay-kay committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    1326940 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    efa96e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13206e9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f031d33 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2e1a402 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    adab677 View commit details
    Browse the repository at this point in the history
  7. Expanded mocks, sured up tests

    - borrowed the windowAlert mocks from PR e-mission#1093, to allow error checking
    - added mockCheck, updated some tests to use to `toEqual()`
    the-bay-kay committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    2d0d321 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bf91301 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7e1790e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f4b0e2d View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Configuration menu
    Copy the full SHA
    db8c7ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2426c4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    08c10f2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e6a21ca View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2e2e2a3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    361cc28 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    570d7a7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    691aeb5 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    84d675a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    163dbb2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2b5da5 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Configuration menu
    Copy the full SHA
    20f5441 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Configuration menu
    Copy the full SHA
    25a064d View commit details
    Browse the repository at this point in the history
  2. Added npm package, fixed HTML formatting

    - NPM package for GeoJSON types
    the-bay-kay committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    fd0c1ab View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Added localization for trip duration

    - Changes utilize "humanize-duration" package
    the-bay-kay committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    9a20378 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d27cefe View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    fe3d417 View commit details
    Browse the repository at this point in the history
  2. Expanded diaryTypes

    the-bay-kay committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    667fec8 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Configuration menu
    Copy the full SHA
    07c5f80 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Added tests for updateUnprocessedInputs

    - Added tests that utilize labelsPRomises
    - Cleaned up mocks, diaryTypes.
    the-bay-kay committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    0d1717d View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    d93da07 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Update www/js/diary/diaryHelper.ts

    Co-authored-by: Jack Greenlee <JackAGreenlee@gmail.com>
    the-bay-kay and JGreenlee committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    b59c65f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92f4a64 View commit details
    Browse the repository at this point in the history
  3. Cleaned up code

    the-bay-kay committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    e3dc66f View commit details
    Browse the repository at this point in the history
  4. add TimestampRange type

    JGreenlee committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d844466 View commit details
    Browse the repository at this point in the history
  5. add getMessagesForInterval to BEMUserCache mock

    This is much like getMessages, but also filters by time in addition to by key.
    Also modified both of these functions to support the `withMetadata` argument in mocks
    JGreenlee committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    c42665f View commit details
    Browse the repository at this point in the history
  6. add tests for updateLocalUnprocessedInputs

    The stategy here is to use the mocked BEMUserCache to actually record some inputs (across both labels&notes and for trip&places), and then check that the new inputs show up in `unprocessedLabels` and `unprocessedNotes` after processing.
    JGreenlee committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    650564a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1cb28c6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b6b7c94 View commit details
    Browse the repository at this point in the history
  9. fix diaryTypes

    A few properties duplicated while resolving merge conflicts
    JGreenlee committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    356336c View commit details
    Browse the repository at this point in the history
  10. fix timelineHelper test

    - made enketoHelper's filterByNameAndVersion accept appConfig as a parameter instead of retrieving it itself. This is 1) simpler, 2) doesn't have to be async anymore and 3) easier to test by swapping out configs
    
    Then, fixed the timelineHelper test by changing the mock config to have "TripConfirmSurvey" and the mock survey response to have the name "TripConfirmSurvey". Now it doesn't get filtered out and the test passes.
    
    Note that eventually we don't want this to be hardcoded, but it will require changes to the structure of the config and maybe a backwards-compat
    JGreenlee committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    f80deb9 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. fix up timelineHelper tests

    - wrap the tests related to unprocessed inputs in a describe(...)
    - on the other mocks in this file, fallback to the original implementation
    - ensure both updateAllUnprocessedInputs and updateLocalUnprocessedInputs are used
    - tidy up the mock configs
    JGreenlee committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    4d664ad View commit details
    Browse the repository at this point in the history
  2. fix broken start time on draft trips

    This was caused by missing parentheses - instead of passing the result of toISO(), we were passing the toISO function itself!
    JGreenlee committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    aa8cbe4 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Configuration menu
    Copy the full SHA
    dfbee1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1fb7c95 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    e69138b View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Update func param types, fix func formatting

    - Expanded types for several function parameters
    - Changed exported functions of `() => {}` format to `function () {}`
    the-bay-kay committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a89f356 View commit details
    Browse the repository at this point in the history
  2. Renamed ServerData to BEMData

    This better reflects the origin of this type: both BEMServerComm
    and BEMUserCache return data of this structure.
    the-bay-kay committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d54ce29 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Imporved test in timelineHelper.test.ts

    Test now compares the unpacked object map to original object.
    the-bay-kay committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    cdb7138 View commit details
    Browse the repository at this point in the history
  2. Ran prettier from www/

    Was running on `js/`, but not mocks; fixed formatting in mocks and
    tests!
    the-bay-kay committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    95d6255 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f73f74 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f54257b View commit details
    Browse the repository at this point in the history