Allow bower to be run as root #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, we get the following error while running in a docker container ``` Updating bower bower ESUDO Cannot be run with sudo Additional error details: Since bower is a user command, there is no need to execute it with superuser permissions. If you're having permission errors when using bower without sudo, please spend a few minutes learning more about how your system should work and make any necessary repairs. You can however run a command with sudo using "--allow-root" option ``` Since the default user in the container is `root`, this is actually an expected use case for us. I tried to avoid this by calling `bower update --allow-root` in the docker setup script e-mission/e-mission-docker#18 But that ran into multiple inconsistencies ( e-mission/e-mission-docs#657 (comment) e-mission/e-mission-docs#657 (comment) ) In order to avoid more bitrotted containers, just changing the code in the setup script so it works in the container as well This fixes e-mission/e-mission-docs#657
shankari
added a commit
to shankari/e-mission-docker
that referenced
this pull request
Aug 9, 2021
Duplicating the command led to multiple inconsistencies (
e-mission/e-mission-docs#657 (comment)
e-mission/e-mission-docs#657 (comment)
)
So I changed the code in the phone repo instead (e-mission/e-mission-phone#776)
and switched to using only the setup scripts here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, we get the following error while running in a docker container
Since the default user in the container is
root, this is actually an expecteduse case for us.
I tried to avoid this by calling
bower update --allow-rootin the dockersetup script e-mission/e-mission-docker#18
But that ran into multiple inconsistencies (
e-mission/e-mission-docs#657 (comment)
e-mission/e-mission-docs#657 (comment)
)
In order to avoid more bitrotted containers, just changing the code in the
setup script so it works in the container as well
This fixes e-mission/e-mission-docs#657