Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docker images for the emission-server + updated docker instructions #617

Closed
wants to merge 49 commits into from

Conversation

alvinalexander
Copy link
Contributor

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@shankari
Copy link
Contributor

Can you pull out only the docker changes into a separate pull request? There is no reason why the docker changes and the trip generator need to be combined, and it makes the PR harder to review.
Also, why do a two step process with e-mission-server-base and e-mission-server? Can't you include the environment variables directly in e-mission-server? Can you document your rationale?

Also, what is setup/alvin_environment.yml? Doesn't seem to be used anywhere...

@alvinalexander
Copy link
Contributor Author

Reason for two images: The base image is less like to change and takes a long time to build(~6GB). The server-image is more likely to change and can be built in a couple seconds. For instance, you might want to add or remove environment variables, change the startup shell script, mount different config files etc. However, it seems unnecessary to rebuild the whole image(pull from github, install the conda env etc.) everytime you want to make changes to the configuration of the server.

@alvinalexander
Copy link
Contributor Author

setup/alvin_environemnt.yml includes the packages installed to create the data generator

@shankari
Copy link
Contributor

shankari commented Dec 4, 2018

The base image is less like to change and takes a long time to build(~6GB).

The base image is no longer 6GB after the shift from anaconda -> miniconda. It is more like 2GB,
https://hub.docker.com/r/emission/e-mission-server/tags/
and can potentially get smaller as we prune the set of packages based on what @Skxu3 finds for the minimal install.

So I don't think that the split is necessary and would prefer to have one file until it stabilizes with the enclave code.

@shankari
Copy link
Contributor

shankari commented Dec 5, 2018

superceded by #618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants