-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New docker images for the emission-server + updated docker instructions #617
Conversation
…at_next_location. Before it resturn a integer timestamp. That lead to multiple location entries having the exact same time stamp. Had to include microseconds in timestamp to reduce likelyhood of two entries having the same timestamp
Can one of the admins verify this patch? |
Can you pull out only the docker changes into a separate pull request? There is no reason why the docker changes and the trip generator need to be combined, and it makes the PR harder to review. Also, what is |
Reason for two images: The base image is less like to change and takes a long time to build(~6GB). The server-image is more likely to change and can be built in a couple seconds. For instance, you might want to add or remove environment variables, change the startup shell script, mount different config files etc. However, it seems unnecessary to rebuild the whole image(pull from github, install the conda env etc.) everytime you want to make changes to the configuration of the server. |
setup/alvin_environemnt.yml includes the packages installed to create the data generator |
The base image is no longer 6GB after the shift from anaconda -> miniconda. It is more like 2GB, So I don't think that the split is necessary and would prefer to have one file until it stabilizes with the enclave code. |
superceded by #618 |
No description provided.