Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the webapp from the server #854

Merged
merged 3 commits into from
Jun 5, 2022

Conversation

shankari
Copy link
Contributor

@shankari shankari commented Jun 5, 2022

As part of modularizing the platform, let's delete the webapp from the server code
We should create a separate webapp microservice, presumably using node.js so
that we can iterate on it separately.

This should also significantly lower the space taken by the e-mission-server
repo, simplify its dependencies, and stop generating dependabot alerts.

As part of modularizing the platform, let's delete the webapp from the server code
We should create a separate webapp microservice, presumably using node.js so
that we can iterate on it separately.

This should also significantly lower the space taken by the e-mission-server
repo, simplify its dependencies, and stop generating dependabot alerts.
@shankari
Copy link
Contributor Author

shankari commented Jun 5, 2022

We now have a 404 when we access the index.html

Screen Shot 2022-06-04 at 6 09 35 PM

@shankari
Copy link
Contributor Author

shankari commented Jun 5, 2022

Using the error redirect functionality to redirect all unknown pages to the openpath page

However, the redirect method didn't work

Used a manual redirect instead and it works

Redirecting to the openpath page "https://www.nrel.gov/transportation/openpath.html" on 404....

Instead of a weird 404 page.
Since this is approved by NREL comms, we don't need any other 404 or index page for now
@shankari
Copy link
Contributor Author

shankari commented Jun 5, 2022

Given that we don't have an entry for index.html, and we redirect all missing URLs to the OpenPATH site, maybe we are done wrt "change the default index.html for the container". We can even remove the index.html from the docker repository, but not sure we need to do that right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant