Aug 10th Feedback #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we got back a few changes from the appendix document today, and these are the ones I have been able to implement -- some are translations for non-translated sections
This is a custom survey for deployment in the usaid-laos-ev project -- it adapts a few of the questions to be more contextually appropriate
I tested this using the files uploaded to my repo, so once the new files come into main this path should work
|
we're waiting now on a decision about what language (since we don't currently support 2) the contact info should be in |
I tested the survey in the config locally, and accidentally committed the change
Abby-Wheelis
commented
Aug 10, 2023
switching the admin_contact to Lao, had to choose just 1 language this time - hope to internationalize in the future
|
After changing the contact info to Lao, we've addressed the last of the issue identified in issue#943 and should now have an app that can work in Lao! |
shankari
approved these changes
Aug 11, 2023
| @@ -67,7 +67,7 @@ <h3>Join your NREL OpenPATH-powered study!</h3> | |||
| {name: "Testing Trip confirm + Time use surveys", joinurl: "nrelopenpath://join_study?label=stage-timeuse&source=github" }, | |||
| {name: "Testing Program", joinurl: "nrelopenpath://join_study?label=stage-program&source=github" }, | |||
| {name: "Testing Study", joinurl: "nrelopenpath://join_study?label=stage-study&source=github" }, | |||
| {name: "UPRM NICR devapp", joinurl: "emission://join_study?label=uprm-nicr&source=github" }, | |||
| {name: "UPRM NICR devapp", joinurl: "emission://join_study?label=uprm-nicr&source=github" } | |||
There was a problem hiding this comment.
nit: extraneous whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some more translations provided for the appendix document today, so those updates will be included in this PR.
A translation was added for the contact section, but we don't currently have things set up to read the contact info from the translated part of the dynamic config file.