Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print CSS parsing errors to stderr #1

Closed
ibc opened this issue Nov 25, 2017 · 3 comments
Closed

Don't print CSS parsing errors to stderr #1

ibc opened this issue Nov 25, 2017 · 3 comments

Comments

@ibc
Copy link

ibc commented Nov 25, 2017

grabity.grab('https://twitter.com/Google/status/933736034726240258')

Output (stderr):

Error: Could not parse CSS stylesheet
    at exports.evaluateStylesheet (/private/tmp/node_modules/jsdom/lib/jsdom/living/helpers/stylesheets.js:18:21)

I don't understand yet why this module requires jsdom (I expect it could just parse an HTML file with other tools, rather than using jsdom which also tries to parse CSS and so on).

@e-oj
Copy link
Owner

e-oj commented Nov 25, 2017

Thanks for catching this. It'll be fixed asap.

don't understand yet why this module requires jsdom (I expect it could just parse an HTML file with other tools, rather than using jsdom which also tries to parse CSS and so on).

Apparently, the performance benefits of skipping css and js processing are overstated

@e-oj
Copy link
Owner

e-oj commented Nov 25, 2017

This has been fixed. Update your grabity version and it should be fine.

@e-oj e-oj closed this as completed Nov 25, 2017
@ibc
Copy link
Author

ibc commented Nov 25, 2017

Thanks a lot for so fast fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants