Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature allow global server url #11

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

pixelwhip
Copy link
Contributor

@pixelwhip pixelwhip commented Feb 28, 2024

Related to Issue #10 Makes the url parameter optional.

Fixes #10.

@e0ipso
Copy link
Owner

e0ipso commented Feb 28, 2024

I am assuming this goes hand in hand with a patch to the Storybook module. Can you link it here as well?

@pixelwhip
Copy link
Contributor Author

Yeah, just realized that a few minutes ago. I still need to create that issue and a patch. My thought is to add another command line option. Something like --exclude-server-url. Any thoughts on that?

@pixelwhip
Copy link
Contributor Author

Here is the related D.O. issue that takes advantage of this change by adding am --omit-server-url option to the drush command. https://www.drupal.org/project/storybook/issues/3424336

@e0ipso e0ipso merged commit 21434dc into e0ipso:main Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the server url to be set as a global parameter
2 participants