problem with forum_sub and php 7.1.6

[Jimmi08]

I tested this on php 7 (probably 7.0) on localhost and it worked without problems

On live site I couldn't get forum_sub dropdown displayed and only difference is php version. This part:

			$data = e107::getDb()->retrieve('forum', 'forum_id,forum_name,forum_parent', 'forum_id != 0',true);
			$this->forumParents[0] = FORLAN_216;
			$forumSubParents = array();

			foreach($data as $val)
			{
				$id = $val['forum_id'];

				if($val['forum_parent'] == 0)
				{
					$this->forumParents[$id] = $val['forum_name'];
				}
				else
				{
					$forumSubParents[$id] = $val['forum_name'];
				}

			}

			$this->fields['forum_parent']['writeParms'] = $this->forumParents;
			$this->fields['forum_sub']['writeParms']['optArray'] = $forumSubParents;
			$this->fields['forum_sub']['writeParms']['default'] = 'blank';

I tested, that $forumSubParents is correctly filled. Because forum_parent dropdown works, I used $this->forumParents as value for forum_sub and nothing was displayed.

Only way I was able to fix it and get dropdown displayd was this:
$this->fields['forum_sub']['writeParms'] = $forumSubParents;
but this way I need always set blank page.

---

this is not related but I think that correct query should be (added forum_sub), so you can add as forum_sub only forum that is not already assigned to some forum.

$data = e107::getDb()->retrieve('forum', 'forum_id,forum_name,forum_parent,forum_sub', 'forum_id != 0',true);

				else
				{
          	if($val['forum_sub'] == 0)
    				{
    					$forumSubParents[$id] = $val['forum_name'];
    				}
					
				}

[Jimmi08]

closing in favour #2870