Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Admin with only "Quick Add User" permission can see all users and access inline edit for all #5045

Closed
Vodhin opened this issue Jul 13, 2023 · 1 comment
Labels
type: bug A problem that should not be happening
Milestone

Comments

@Vodhin
Copy link

Vodhin commented Jul 13, 2023

Bug Description

An Admin with only "Quick Add User" permission can see all users and access inline edit functions including display name, real name, email address, and assign user classes. Since Login Names are visible, it might be possible to change another Admin's email and then use the Forgot Password to change their password, locking them out and gaining whatever permissions they have.

How to Reproduce

Steps to reproduce the behavior:

  1. Make a new user account to test
  2. Go To e107_admin/users.php and make that user an Admin
  3. Go to e107_admin/administrator.php and Edit that user's permissions
  4. Check only Quick Add User in the General Tab
  5. Log Out
  6. Log In as that User, go to e107_admin/users.php and change any users' email, display name, and whatever.

Expected Behavior

User should only see the Quick Add User Form and no user list (or a list of only users they have added might be nice).

@Vodhin Vodhin added the type: bug A problem that should not be happening label Jul 13, 2023
@CaMer0n CaMer0n added this to the e107 2.3.3 milestone Aug 22, 2023
@CaMer0n
Copy link
Member

CaMer0n commented Aug 22, 2023

Thank you @Vodhin !! I didn't hide the user list, but I did disable 'inline' editing, which prevents any editing of it. I also prevented this type of admin from creating new admins. (ie. elevated access).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

2 participants