Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Change length of newsfeed_image field in db #5108

Closed
Alex-e107nl opened this issue Nov 18, 2023 · 0 comments
Closed

[Feature request]: Change length of newsfeed_image field in db #5108

Alex-e107nl opened this issue Nov 18, 2023 · 0 comments
Labels
type: enhancement An improvement or new feature request type: question An ask about behavior that is not found documented anywhere
Milestone

Comments

@Alex-e107nl
Copy link

Question

I was setting up the news feed plugin to show news from other websites on an e107 website. That worked fine, but it turned out that loading a logo was not possible because the input field for the image link was too small. Can that be adjusted?

Expected Source

I looked at e107_plugins/newsfeed/newsfeed_sql.php

CREATE TABLE newsfeed (
  newsfeed_id int(10) unsigned NOT NULL auto_increment,
  newsfeed_name varchar(150) NOT NULL default '',
  newsfeed_url varchar(250) NOT NULL default '',
  newsfeed_data longtext NOT NULL,
  newsfeed_timestamp int(10) unsigned NOT NULL default '0',
  newsfeed_description text NOT NULL,
  newsfeed_image varchar(100) NOT NULL default '',
  newsfeed_active tinyint(1) unsigned NOT NULL default '0',
  newsfeed_updateint int(10) unsigned NOT NULL default '0',
  PRIMARY KEY  (newsfeed_id)
) ENGINE=MyISAM;

If the newsfeed_image varchar(100) NOT NULL default '', is changed from 100 to 250, problem is solved...

Can that be changed without problems?

Additional Context

I prefer to use the logo of the feed providers website so that when it changes it is immediately visible or at least it is clear that something has changed. 100 characters turns out to be too few...

@Alex-e107nl Alex-e107nl added the type: question An ask about behavior that is not found documented anywhere label Nov 18, 2023
@CaMer0n CaMer0n added the type: enhancement An improvement or new feature request label Nov 20, 2023
@CaMer0n CaMer0n added this to the e107 2.3.3 milestone Nov 20, 2023
@CaMer0n CaMer0n changed the title [Question]: Change the newsfeed_image varchar of the newsfeed plugin? Newsfeed image field length is too short. Nov 20, 2023
@Moc Moc changed the title Newsfeed image field length is too short. [Feature request]: Change length of newsfeed_image field in db Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request type: question An ask about behavior that is not found documented anywhere
Projects
None yet
Development

No branches or pull requests

2 participants