Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong Content-Type for responses #1

Merged
merged 1 commit into from Apr 14, 2017
Merged

Fix wrong Content-Type for responses #1

merged 1 commit into from Apr 14, 2017

Conversation

ilpianista
Copy link

RFC 5849 specify to use application/x-www-form-urlencoded as Content-Type response.

This fixes pump-io/pump.io#822 issue.

RFC 5849 specify to use application/x-www-form-urlencoded as Content-Type response.
Copy link
Collaborator

@strugee strugee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you confirm that this fixes the bug in pump.io? If you have a local install you can have pump.io use your changes by running npm install ilpianista/connect-auth

@ilpianista
Copy link
Author

Yes, I already tested it!

@strugee
Copy link
Collaborator

strugee commented Apr 14, 2017

Sweet. Thank you!

@strugee strugee merged commit 57816e5 into e14n:master Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants