Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parentheses in sandbox.close() call #359

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ggorlen
Copy link
Contributor

@ggorlen ggorlen commented Apr 18, 2024

sandbox.close would be a no-op without parentheses to invoke the function.

Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: 8bb7226

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jakubno
Copy link
Member

jakubno commented Apr 18, 2024

Hi @ggorlen, nice catch, thanks!

@jakubno jakubno merged commit 9838570 into e2b-dev:main Apr 18, 2024
1 of 3 checks passed
@ggorlen ggorlen deleted the add-missing-parens branch April 18, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants