Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing MMDS in some sandboxes #124

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Fix missing MMDS in some sandboxes #124

merged 2 commits into from
Apr 7, 2024

Conversation

ValentaTomas
Copy link
Member

@ValentaTomas ValentaTomas commented Apr 5, 2024 •
edited

This moves MMDS setup from a goroutine — errors in MMDS setup will also cancel the sandbox spawn.

Fixes #123

@ValentaTomas ValentaTomas changed the title Fix missing MMDS in Fix missing MMDS in some sandboxes Apr 5, 2024
@ValentaTomas ValentaTomas added the bug Something isn't working label Apr 5, 2024
@ValentaTomas
Copy link
Member Author

The cause of the problem was using the childCtx that gets closed after the function end.
Getting the MMDS out of the goroutine have very little time cost and ensures it gets set.

@ValentaTomas ValentaTomas merged commit e158db0 into staging Apr 7, 2024
@ValentaTomas ValentaTomas deleted the mmds branch April 7, 2024 19:20
@ValentaTomas ValentaTomas mentioned this pull request Apr 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubno jakubno jakubno approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ValentaTomas @jakubno