Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding workflow durability by allowing persistence between each stage #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cortexteam
Copy link

Adding an optional callback which can be used to persist the message state at each workflow stage to allow long-running workflows to become durable and resumable.

@agebert
Copy link
Member

agebert commented Nov 30, 2018

@cyrilschmitt what do you think about this enhancement?

Copy link
Member

@cyrilschmitt cyrilschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello cortexteam,

Thank you for contributing, the ideas are valid but I have some remarks before merging this.

I would like it in multiple commits because I think there are different unrelated changes:

  • getNumberOfProcesses
  • delete and _autoCleanFinishedProcess (these are related so OK for both in one commit)
  • persist and resumeProcess (also related so one commit)

I think resumeProcess should also take processName parameter because in case the manager have multiple processDefinitions then this can be wrong:
Object.keys(self._processDefinitions)[0]
It would alsways use the first definition so replace by processName parameter.

Regards,
Cyril

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants