-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml #617
base: develop
Are you sure you want to change the base?
Conversation
added change to CHANGELOG.rst version in __init__.py and doc/source/conf.py is now read from pyproject.toml removed content of setup.py removed calls to setup.py in workflows as calling setup.py directly is deprecated
removed explicit install of pandapower master
… into feature/pyproject-toml
@SimonRubenDrauz, @mfranz13: This PR looks good to me, I think we should merge it soon. The only part that is still unclear to me is what pandapower version should be used in the tests (as @KS-HTK mentioned, it is not usual to install from develop, but that would mean less sync between pandapower and pandapipes). We should clarify that first. |
I did not change any test regarding the normal code base. What I changed is the explicit installation of pandapower master branch (release versions). There should never be a commit to pandapower master that is not also a release to pypi. So But to add to that mentiond descussion: |
switched from setup.py to pyproject.toml
added change to CHANGELOG.rst
version in init.py and doc/source/conf.py is now read from pyproject.toml removed content of setup.py
removed calls to setup.py in workflows as calling setup.py directly is deprecated
This PR adds one new dependency. sphinx-pyproject
This is to allow the conf.py to read values from the pyproject.toml so incrementing the version there is no longer a manual operation.
I also changed the github workflows to not call setup.py as per this post.
Important:
build does not support zip format. So builds are now tar.gz this should not make a difference to users as it can be installed by pip either way.
also I did not add back the sdist flag, as i do not see why it should not publish a whl on pypi. If this is not desired build can be forced to only build the tar.gz distribution.