Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKAT valid_nested_list_format uses size_t for an integer, num_open, that might go negative #226

Closed
ambrad opened this issue Jun 15, 2022 · 1 comment · Fixed by #229
Closed
Assignees

Comments

@ambrad
Copy link
Member

ambrad commented Jun 15, 2022

Associated warning:

ekat/src/ekat/util/ekat_string_utils.cpp(179): warning: pointless comparison of unsigned integer with zero
@bartgol
Copy link
Contributor

bartgol commented Jun 27, 2022

Thanks! I forgot to add -Wextra to my ekat debug build, and this slipped through the cracks. Will fix.

Side node: imho, such pointless comparisons are potentially dangerous (flawed logic), and gcc should include the warning in -Wall, rather than -Wextra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants