Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HelpPages] JSON response errors when no help pages exist #492

Open
DonovanDMC opened this issue Mar 23, 2023 · 5 comments
Open

[HelpPages] JSON response errors when no help pages exist #492

DonovanDMC opened this issue Mar 23, 2023 · 5 comments

Comments

@DonovanDMC
Copy link
Member

DonovanDMC commented Mar 23, 2023

image

Deleted help pages are also not removed from the cache when they are deleted, so they hang around for 12 hours, or until another help page is created/edited. To be specific, they still show on the index page.

Deleting a wiki page that's being used by a help page will cause an error to be shown on that help page. This is somewhat expected, but something should probably either prevent this, or also delete the help page.
image

Earlopain added a commit that referenced this issue Apr 10, 2023
@Earlopain
Copy link
Collaborator

Fix two things, left the index unexpected error for sometime else. It's probably the same issue as with all the other endpoints where this happens.

@DonovanDMC
Copy link
Member Author

I did want to ask, in the future would you prefer I group things like this, or make a separate issue for each?

@Earlopain
Copy link
Collaborator

Single issues seem preferable to me

@DonovanDMC
Copy link
Member Author

👍 I never know, I didn't want to spam issues just in case

@DonovanDMC
Copy link
Member Author

DonovanDMC commented Apr 11, 2023

Fix two things, left the index unexpected error for sometime else. It's probably the same issue as with all the other endpoints where this happens.

I've definitely seen this in a few other places, namely the alt_list route of the admin/users controller iirc

And a more real world example, /comments.json?group_by=post - exact same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants