[Posts]: Hide disabled comments info better

[DonovanDMC]

Currently, there's a bit of a mix between making disabled comments hard to find, and making them easy to find, as well as leaking a bit of information disabling comments should hide.

This pr:

• Hides the number of comments for non moderators (shows 0), both in the posts list, as well as in the json api
• Removes the comment_disabled flag in api responses
• Excludes the comment_disabled and comment_enabled post events from non-moderators, as this makes it very easy to find posts with disabled comments

In theory the comment count can still be sniffed out with a brute force id:(...) comment_count:, but I don't think there should really be any concern over that.

[Earlopain]

Just get rid of the api field entirely. Not sure what I was thinking including that

[DonovanDMC]

Just get rid of the api field entirely. Not sure what I was thinking including that

I had debated doing that, but didn't want to do a breaking change. Though seeing as that isn't a field really anyone should be relying on, I'm realizing that would have been fine.

[DonovanDMC]

The test didn't fail locally
ughhh

[Earlopain]

I was more meaning something like

def visible_comment_count(user)
  (user.is_moderator? || !is_comment_disabled) ? comment_count : 0
end

Also not really relevant to this, but I'm trying to at least not introduce new dependencies on CurrentUser in anything but controllers. So passing the user into the method is preferable, even if the caller still uses CurrentUser in a non-desireable location. CurrentUser is only set when the controller callbacks fire which messes with a bunch of stuff in jobs, tests and the console.

[DonovanDMC]

I was more meaning something like

def visible_comment_count(user)
  (user.is_moderator? || !is_comment_disabled) ? comment_count : 0
end

Oh, sorry. I interpreted that differently, as you saw. I've changed it to that now.