Issue# 412: Home Replication Long Running Setup with Real Drives #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkadayam
reviewed
May 15, 2024
xiaoxichen
reviewed
May 15, 2024
| @@ -177,7 +178,8 @@ class HSTestHelper { | |||
|
|
|||
| static void start_homestore(const std::string& test_name, std::map< uint32_t, test_params >&& svc_params, | |||
| hs_before_services_starting_cb_t cb = nullptr, bool fake_restart = false, | |||
| bool init_device = true, uint32_t shutdown_delay_sec = 5) { | |||
| bool init_device = true, uint32_t shutdown_delay_sec = 5, | |||
| std::vector< std::string > cust_dev_names = {}) { | |||
There was a problem hiding this comment.
what is cust stands for?
yamingk
commented
May 15, 2024
yamingk
commented
May 15, 2024
src/lib/device/device_manager.cpp
Outdated
| @@ -36,16 +36,19 @@ static int determine_open_flags(io_flag oflags) { | |||
|
|
|||
| switch (oflags) { | |||
| case io_flag::BUFFERED_IO: | |||
| open_flags = O_RDWR | O_CREAT; | |||
| // open_flags = O_RDWR | O_CREAT; | |||
| open_flags = O_RDWR; | |||
There was a problem hiding this comment.
This change doesn't make much difference, but thought is the right thing to do.
PS, 1.3 we also always pass this O_CREAT flag.
yamingk
commented
May 16, 2024
| @@ -113,7 +113,7 @@ if (${io_tests}) | |||
| can_build_epoll_io_tests(epoll_tests) | |||
| if(${epoll_tests}) | |||
| add_test(NAME LogDev-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_log_dev) | |||
| add_test(NAME LogStore-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_log_store) | |||
| #add_test(NAME LogStore-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_log_store) | |||
There was a problem hiding this comment.
hanging in github CI, seen also in other PR's CI build: https://github.com/eBay/HomeStore/actions/runs/9107660378/job/25036931542?pr=426.
seems consistently reproducable
xiaoxichen
reviewed
May 17, 2024
| @@ -113,7 +113,7 @@ if (${io_tests}) | |||
| can_build_epoll_io_tests(epoll_tests) | |||
| if(${epoll_tests}) | |||
| add_test(NAME LogDev-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_log_dev) | |||
| add_test(NAME LogStore-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_log_store) | |||
| #add_test(NAME LogStore-Epoll COMMAND ${CMAKE_BINARY_DIR}/bin/test_log_store) | |||
xiaoxichen
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Command:
./test_raft_repl_dev --gtest_filter=Snapshot_and_Compact --replica_dev_list /dev/data1,/dev/data2,/dev/data3 --num_io=999999 --snapshot_distance=200 --num_raft_logs_resv=20000 --res_mgr_audit_timer_ms=120000
from log, each replica can take the real device with 5TB size and I/Os can be run. Snapshot and Truncation is going through.