Skip to content
This repository has been archived by the owner on Jul 16, 2019. It is now read-only.

Potential enhancement: decouple filter configuration with web.xml init parameters #6

Open
MagIciaNGTAO opened this issue Aug 10, 2014 · 2 comments

Comments

@MagIciaNGTAO
Copy link

It will enable one scenario: changing CORS configuration without restarting the application server.

@mohitsoni
Copy link
Contributor

Sounds interesting, and I think it will be helpful for project in general. How do you propose to do it ?

@MagIciaNGTAO
Copy link
Author

Just grabbed the source. Very compact :). We could do it in two steps I guess.

First step is supporting the following configuration like the way https://bitbucket.org/thetransactioncompany/cors-filter/ does.
<init-param>
<param-name>cors.configurationFile</param-name>
<param-value>cors.properties</param-value>
</init-param>

By doing that, after starting up, our CORSFilter will have internal state configuraed by cors.properties.

The second step (I feel it's still under thought in my mind): If we could have a separated object to represent cors.properties, we just need a 'flush' mechanism we could call from some where else. (I am avoiding race conditions ... and performance :()

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants