ebayui-core-4.5.0 : ebayui-listbox-button should allow class update on re-render

[uachladi]

Bug Report

eBayUI Version: 4.5.0

Description

ebay-listbox-button allows to pass class attribute but does not allow change of class on re-render due to w-preserve-attrs.
https://github.com/eBay/ebayui-core/blob/4.5.0/src/components/ebay-listbox-button/template.marko#L15

@dpiercey @ianmcburnie . This is a high priority for us to get the sellerhub skin upgrade to be completed.

[ianmcburnie]

@uachladi We'll look into it. Just curious to know what kind of class are you changing? Is it a visual change? Or some kind of JS hook? We like to learn how people are using the API :-)

[uachladi]

@ianmcburnie , its just the text color.

[ianmcburnie]

@uachladi Thanks. What does the red colour convey? I'm concerned about accessibility and using colour alone to convey meaning. Actually, I'll ping you offline to chat further...

[ianmcburnie]

@uachladi just checking in... do you still need this?

[uachladi]

@ianmcburnie , yes product wants to keep this.

[agliga]

@uachladi Is this needed on the 4.5.x branch or are you able to upgrade to 5.x` branch in the near future?

[uachladi]

We do not have upgrade in our planning until Q2 2021. It will be needed on 4.5.x branch.

[agliga]

This is also needed in 5.x branch since it has no-update on class for listbox.

[agliga]

Released in 4.5.22