Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebay-select: array.prototype.find causing error in IE #50

Closed
ianmcburnie opened this issue Mar 16, 2018 · 0 comments
Closed

ebay-select: array.prototype.find causing error in IE #50

ianmcburnie opened this issue Mar 16, 2018 · 0 comments
Assignees
@seangates
Labels
component: select severity: blocker For "type: bug" only type: bug

Comments

@ianmcburnie
Copy link
Contributor

Array.prototype.find is not supported in IE

https://github.com/eBay/ebayui-core/blob/0.1.0/src/components/ebay-select/index.js#L31

We either refactor in ES5 or use a transform/polyfill.

ES5 will work for quick fix, but for long term I say we should be leaning towards transform/polyfill.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seangates seangates

Labels
component: select severity: blocker For "type: bug" only type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ianmcburnie @jammur @seangates