Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: allow local demo to optionally run on transpiled dist code #52

Closed
ianmcburnie opened this issue Mar 16, 2018 · 2 comments
Closed

Comments

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Mar 16, 2018

So that we can catch and fix bugs in all browsers, we need to be running the transpiled dist code in our local demo.

Running yarn start should add a transpile step to it's pipeline, and local demo should have capability to be running on the transpiled code in dist.

Related to: #59

@yomed
Copy link
Contributor

yomed commented Mar 16, 2018

As discussed, the default case can be against src/, but there should be an easy way to run against dist/ for debugging edge cases. The prepublish and postpublish scripts take care of most of the dist setup, but we would also need to have a script that points demo to dist/. We could potentially make the publishing scripts more generic to achieve this.

@ianmcburnie ianmcburnie changed the title Build: we need to be running the transpiled dist code in our local demo Build: run transpiled dist code in local demo Mar 16, 2018
@seangates seangates changed the title Build: run transpiled dist code in local demo Build: allow local demo to optionally run on transpiled dist code Mar 20, 2018
@DylanPiercey
Copy link
Member

After talking with @yomed I think an easier solution here would just be to conditionally add the lasso-babel-transform to the demo based on NODE_ENV.

We could then trigger the demo to start in dist/production mode by using NODE_ENV=production npm start and also probably have an alias like npm start:prod or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v0.2.x
  
Done
Development

No branches or pull requests

4 participants