Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake-menu: number badge not supported #2208

Closed
1 task done
darkwebdev opened this issue Nov 15, 2023 · 0 comments
Closed
1 task done

fake-menu: number badge not supported #2208

darkwebdev opened this issue Nov 15, 2023 · 0 comments

Comments

@darkwebdev
Copy link
Contributor

darkwebdev commented Nov 15, 2023

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

Not sure if it's a bug or intended behaviour, but:
when I use number badges in fake-menu they lack margins (like in a normal menu):
image

image

Expected behavior

image

Skin version

16

Device/OS/Browser info

firefox mac

Relevant code block

The problem is here:

.menu__item .badge {

.menu__item > svg.icon--tick-16:last-child,
.fake-menu__item > svg.icon--tick-16:last-child,
.menu__item .badge {
    margin-left: var(--spacing-100);
    margin-right: var(--spacing-100);
}

we just need to add another selector to this rule:

.fake-menu__item .badge

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants