You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, our toggle-buttons within a toggle-button-group do not have the same height so when the content of one button is taller than others, the layout is not balanced.
Additionally, the initial iteration of toggle-button-group was semi-responsive with the use of 'desired columns` for the preferred number of buttons per row before wrapping, which was not guaranteed.
Since these two features are extremely intertwined because of a shift to use display: grid and both require a breaking change, it's best to do them at the same time.
For this issue,
Add equal heights feature to toggle-button-group so that an increase in height of one button makes all buttons the same height, whether they are on a single row or span multiple rows.
Make toggle-button-group fully responsive using container queries.
Screenshots
Current:
Desired:
Figma link
No response
Engineering pre-requisites
Successful design review with Design System Team.
Supports dark mode.
Supports responsive design.
Tokens have been provided (or already exist).
Successful accessibility review with Core A11Y Team.
Successful frontend review with eBayUI Team.
The text was updated successfully, but these errors were encountered:
Most likely, we'll have to start using flex for toggle-button-group, which will be a slight abandoning of inline-block, which allows more easy wrapping. The solution might need to make clever use of flex on the <li>s, something like,
/* width percentages relative to 100% / [columns] *//* subtracting the margins from both sides */flex:10calc(33%-(var(--spacing-50)*2));
Most likely, we'll have to start using flex for toggle-button-group, which will be a slight abandoning of inline-block, which allows more easy wrapping. The solution might need to make clever use of flex on the <li>s, something like,
/* width percentages relative to 100% / [columns] *//* subtracting the margins from both sides */flex:10calc(33%-(var(--spacing-50)*2));
This option only allowed equal heights across a single row. Once the row wraps, heights are reset. This means that each row can have a different height.
ArtBlue
changed the title
toggle-button-group: add equal heights to toggle buttons in group
toggle-button-group: add equal heights and make fully responsive
May 21, 2024
Description
Currently, our
toggle-buttons
within atoggle-button-group
do not have the same height so when the content of one button is taller than others, the layout is not balanced.Additionally, the initial iteration of
toggle-button-group
was semi-responsive with the use of 'desired columns` for the preferred number of buttons per row before wrapping, which was not guaranteed.Since these two features are extremely intertwined because of a shift to use
display: grid
and both require a breaking change, it's best to do them at the same time.For this issue,
toggle-button-group
so that an increase in height of one button makes all buttons the same height, whether they are on a single row or span multiple rows.toggle-button-group
fully responsive using container queries.Screenshots
Current:
Desired:
Figma link
No response
Engineering pre-requisites
The text was updated successfully, but these errors were encountered: