New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache expression #16

Open

devrck wants to merge 12 commits into eMAGTechLabs:master from devrck:cache-expression

Contributor

devrck commented Dec 27, 2016

No description provided.

Bogdan Rancichi added 4 commits

December 16, 2016 12:05


          initial cache class start

619b728


          implement cache expression fully

e1b9786


          added symfony/expression as a dependecy

837a498


          created a test for sf expressions

0c8645c

coveralls commented Dec 27, 2016 •

edited

Loading

Coverage decreased (-0.1%) to 93.75% when pulling 0c8645c on devrck:cache-expression into bf9c1ae on eMAGTechLabs:master.

2 similar comments

coveralls commented Dec 27, 2016

Coverage decreased (-0.1%) to 93.75% when pulling 0c8645c on devrck:cache-expression into bf9c1ae on eMAGTechLabs:master.

coveralls commented Dec 27, 2016

Coverage decreased (-0.1%) to 93.75% when pulling 0c8645c on devrck:cache-expression into bf9c1ae on eMAGTechLabs:master.

alexbumbacea reviewed

View reviewed changes

composer.json

@@ @@ -14,7 +14,8 @@ @@
                   "ocramius/proxy-manager": "2.*",
                   "psr/log": "1.*",
                   "psr/cache": "1.0.*",
-                  "doctrine/annotations": "1.3.*"
+                  "doctrine/annotations": "1.3.*",
+                  "symfony/expression-language": "3.*"
                 },

Contributor

alexbumbacea Dec 27, 2016

expression-language can be put as suggested?

Contributor Author

devrck Dec 27, 2016

If you put it as suggested you can't use @CacheExpression annotation I think.

Contributor

alexbumbacea Dec 27, 2016

you can put it in both require-dev (so you can test it) and in suggests.
Who requires usage of expression should include the package explictly

alexbumbacea reviewed

View reviewed changes

src/CacheBundle/Annotation/CacheExpression.php Outdated

+                          }
+                          $this->expressionLanguage = new ExpressionLanguage(new FilesystemAdapter('expr_cache'));
+                      }

Contributor

alexbumbacea Dec 27, 2016

can we convert this into service based? This way it will be easier if someone wants to use anything else here...

Contributor Author

devrck Dec 27, 2016

Your talkin' about the new FilesystemAdapter?

Contributor

alexbumbacea Dec 27, 2016 •

edited

Loading

Yep, but also maybe classes that extend the base ExpressionLanguage...

alexbumbacea reviewed

View reviewed changes

tests/Helpers/CacheableClass.php

+                  public function calculateCachePrefix() : string
+                  {
+                      return 'xyz';
+                  }

Contributor

alexbumbacea Dec 27, 2016

can we also update the readme ?

Contributor Author

devrck Dec 27, 2016

Yep I will.

Bogdan Rancichi added 4 commits

January 3, 2017 21:40


          Merge remote-tracking branch 'origin/master' into cache-expression

fa5dba9

Conflicts:
	src/ProxyManager/CacheableClassTrait.php
	tests/CacheWrapperTest.php
	tests/Helpers/CacheableClass.php


          move to new namespace

69c081f


          expression language will be injected

1aeedbe


          add expression language from configuration of the bundle

48aea7e

coveralls commented Jan 3, 2017 •

edited

Loading

Coverage decreased (-98.3%) to 0.0% when pulling 48aea7e on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

1 similar comment

coveralls commented Jan 3, 2017

Coverage decreased (-98.3%) to 0.0% when pulling 48aea7e on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

Bogdan Rancichi added 3 commits

January 3, 2017 22:26


          moved to suggest & require-dev for expression_language

968484a


          make incorrect cache service configuration file more clear

db875ca


          complete cache expressions

coveralls commented Jan 7, 2017 •

edited

Loading

Coverage increased (+0.7%) to 99.01% when pulling 6196890 on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

4 similar comments

coveralls commented Jan 7, 2017

Coverage increased (+0.7%) to 99.01% when pulling 6196890 on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

coveralls commented Jan 7, 2017

Coverage increased (+0.7%) to 99.01% when pulling 6196890 on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

coveralls commented Jan 7, 2017

Coverage increased (+0.7%) to 99.01% when pulling 6196890 on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

coveralls commented Jan 7, 2017

Coverage increased (+0.7%) to 99.01% when pulling 6196890 on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.


          added README

ac8f56a

coveralls commented Jan 7, 2017 •

edited

Loading

Coverage increased (+0.7%) to 99.01% when pulling ac8f56a on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

4 similar comments

coveralls commented Jan 7, 2017

Coverage increased (+0.7%) to 99.01% when pulling ac8f56a on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

coveralls commented Jan 7, 2017

Coverage increased (+0.7%) to 99.01% when pulling ac8f56a on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

coveralls commented Jan 7, 2017

Coverage increased (+0.7%) to 99.01% when pulling ac8f56a on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

coveralls commented Jan 7, 2017

Coverage increased (+0.7%) to 99.01% when pulling ac8f56a on devrck:cache-expression into 75aa68b on eMAGTechLabs:master.

alexbumbacea reviewed

View reviewed changes

src/DependencyInjection/EmagCacheExtension.php

+                      $expressionLanguage = new \ReflectionClass($container->getDefinition($config['expression_language'])->getClass());
+                      if ($expressionLanguage->getName() !== ExpressionLanguage::class) {
+                          throw new CacheException(sprintf('You must provide a valid Expression Language service'));

Contributor

alexbumbacea Jan 8, 2017

Too exact class match. You should be able to provide anything that extends expressionLanguage.

Contributor Author

devrck Jan 9, 2017

Of course I will fix it.

alexbumbacea reviewed

View reviewed changes

src/DependencyInjection/EmagCacheExtension.php

+                              'emag.cache.expression.language'=> (new Definition(ExpressionLanguage::class))->addArgument(new Reference('emag.cache.filesystem.adapter')),
+                          ]);
+                      } elseif ($config['expression_language']) {
+                          $container->setAlias('emag.cache.expression.language', $config['expression_language']);

Contributor

alexbumbacea Jan 8, 2017

i would reverse the if. it's cheaper... :)

Contributor Author

devrck Jan 9, 2017

Will do.

alexbumbacea reviewed

View reviewed changes

src/ProxyManager/CacheableClassTrait.php

@@ @@ -23,6 +25,8 @@ @@
                    */
                   protected $readerForCacheMethod;
+                  protected $__expressionLanguage;

Contributor

alexbumbacea Jan 8, 2017

what's with the __ ?

Contributor Author

devrck Jan 9, 2017

To avoid parameter collision.

devrck requested a review from danieltoader as a code owner

February 16, 2021 13:34

Member

danieltoader commented Feb 16, 2021

Will take a look into it, but it requires a few changes to be included in the new version with the refactor done for v5.0

danieltoader force-pushed the master branch 3 times, most recently from 551b036 to 7f19c25 Compare

February 17, 2021 17:01

danieltoader force-pushed the master branch 3 times, most recently from 9bc4395 to 3ea90d7 Compare

February 26, 2021 02:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment