Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well-known port calculation on endpoint locators [5040] #475

Merged
merged 2 commits into from Apr 30, 2019

Conversation

MiguelCompany
Copy link
Member

This PR enables automatic calculation of the port when receiving a value of 0 on the endpoint custom locators.

Signed-off-by: Miguel Company MiguelCompany@eprosima.com

@MiguelCompany MiguelCompany mentioned this pull request Apr 2, 2019
31 tasks
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

LuisGP
LuisGP previously approved these changes Apr 9, 2019
Copy link
Contributor

@LuisGP LuisGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be possible to create a common method to avoid dupped code in createWriter and createReader methods?

@LuisGP LuisGP assigned MiguelCompany and unassigned LuisGP Apr 9, 2019
@MiguelCompany MiguelCompany force-pushed the feature/well-known-ports-on-ebndpoints branch 2 times, most recently from bb64b16 to 6fadc1b Compare April 29, 2019 13:32
@MiguelCompany MiguelCompany force-pushed the feature/well-known-ports-on-ebndpoints branch from 6fadc1b to 31c24da Compare April 29, 2019 14:28
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware richiware merged commit 9e13428 into develop Apr 30, 2019
@richiware richiware deleted the feature/well-known-ports-on-ebndpoints branch May 3, 2019 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants