Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure era5-Land does not call ensemble product type #131

Merged
merged 3 commits into from Nov 30, 2022
Merged

Ensure era5-Land does not call ensemble product type #131

merged 3 commits into from Nov 30, 2022

Conversation

bvreede
Copy link
Contributor

@bvreede bvreede commented Nov 23, 2022

Fixes #130.

@codecov
Copy link

codecov bot commented Nov 23, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (main@2b8e449). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage        ?   98.94%           
=======================================
  Files           ?        6           
  Lines           ?      380           
  Branches        ?        0           
=======================================
  Hits            ?      376           
  Misses          ?        4           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8e449...7066edf. Read the comment docs.

@bvreede bvreede mentioned this pull request Nov 23, 2022
Closed
@bvreede
Copy link
Contributor Author

bvreede commented Nov 23, 2022

@malininae Could you take a look at this PR? I can't seem to officially request your review, but since you raised the issue, I'd be very happy with your eyes on this fix! :)

malininae
malininae suggested changes Nov 29, 2022
View reviewed changes
era5cli/fetch.py Outdated Show resolved Hide resolved
era5cli/fetch.py Outdated Show resolved Hide resolved
tests/test_fetch.py Outdated Show resolved Hide resolved
malininae
malininae approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@malininae malininae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is great, thanks!

@bvreede
Copy link
Contributor Author

bvreede commented Nov 30, 2022

@Peter9192 could you hit 'approve' please 😅 I can't merge with @malininae's Approved review or add my own...

@bvreede bvreede merged commit fc8f6df into main Nov 30, 2022
@bvreede bvreede deleted the incompatible-options-130 branch November 30, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peter9192 Peter9192 Peter9192 approved these changes

@malininae malininae malininae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No error message if using --land and --ensemble
3 participants
@bvreede @Peter9192 @malininae