-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marrmotm14 class #100
Add marrmotm14 class #100
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: Stefan Verhoeven <s.verhoeven@esciencecenter.nl>
@sverhoeven and @Peter9192 Please review this PR when one of you has time. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR passes the acceptance criteria.
The tests and notebook ran successfully
I have some minor suggestions for improvements.
Returns: | ||
Path to config file and path to config directory | ||
""" | ||
arguments = vars() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not know you could use vars()
to get the arguments as a dict. Thanks for the lesson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this is one of the built-in functions, here I think that I could use both vars() and locals(). But I chose the former.
Co-authored-by: Stefan Verhoeven <s.verhoeven@esciencecenter.nl>
Co-authored-by: Stefan Verhoeven <s.verhoeven@esciencecenter.nl>
Thank you for reviewing and helpful suggestions. |
This branch is based on the branch update_forcing_in_marrmotm01_class.