Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, tests, docs build of the plugin-branch #348

Merged
merged 30 commits into from
Jun 7, 2023

Conversation

BSchilperoort
Copy link
Contributor

@BSchilperoort BSchilperoort commented May 30, 2023

  • Fix CI workflows
  • move models, forcing etc. to /base
  • Fix tests
  • Fix docs
  • update docs see Update outdated docs #350
  • Remove Python 3.11
  • Implement new github download

Note: the following tests are still skipped (broken or superceded):

@BSchilperoort BSchilperoort changed the base branch from main to plugin_folder2 May 30, 2023 09:28
@BSchilperoort BSchilperoort linked an issue Jun 2, 2023 that may be closed by this pull request
@BSchilperoort BSchilperoort marked this pull request as ready for review June 7, 2023 12:54
Copy link
Collaborator

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair-reviewed, nice work!

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.0% 91.0% Coverage
0.0% 0.0% Duplication

@BSchilperoort BSchilperoort changed the title Plugin folder (Bart branch) Fix CI, tests, docs build, ... Jun 7, 2023
@BSchilperoort BSchilperoort changed the title Fix CI, tests, docs build, ... Fix CI, tests, docs build of the plugin-branch Jun 7, 2023
@BSchilperoort BSchilperoort merged commit d36e04c into plugin_folder2 Jun 7, 2023
5 checks passed
@BSchilperoort BSchilperoort deleted the plugin_folder-bart branch June 7, 2023 14:55
BSchilperoort added a commit that referenced this pull request Jun 8, 2023
…ructure (#347)

* Move models to plugin folder

* Move forcing and example parameter sets to plugins (and lisflood config)

* Move model-specific tests to model plugin folder in tests

* Move remaining tests into src folder and add ewatercycle.testing module

This triggers circular import issues

* fix circular import by splitting in model and models

* fix test paths

* Use entry points for forcings + require python >=3.10

* Not longer need typing_extensions

* Add typing back

* Use SomethingDownloader to download example parameter set

* Refactor parameter sets

* Fix CI, tests, docs build of the plugin-branch (#348)

* Change python versions to strings in CI workflows

* Remove conda python<3.11 pin.

* Moved abstract model to base/model.py

* Refactor models folder to file

* Refactor forcing. Default to base, rest to forcing.py

* Remove parametersetdb.ParameterSet

* Move case sensitive config parser to util.py

* Removed parametersetdb. Still used parts moved.

* Refactored forcing sources, ewc/forcing.py.

* Fix DefaultForc test, get name from __fields__

* Add type hinting to forcing sources

* Fix src/ tests

* Fix plugin tests

* Apply linters: black, isort.

* Remove python 3.11

* Fix setup-cfg-fmt issue

* Fix pre-commit. Removed `setup-cfg-fmt`: incompatible w/ Py3.10

* Silence sonarcloud false positive

* Add new github downloader

* Fix pcrglob test, parameterset tests

* Please linters

* Add RTD config file

* Add pydantic to docs requirements

* Update conf.py and docs/requirements.txt to fix docs

* Bump CI actions/checkout to v3.

* pre-commit

* Make SonarCloud happy

* Fix docs: move to sphinx-autoapi

* Make yamllint happy

* Removed skipped tests from parameter_sets/test_example.py

---------

Co-authored-by: sverhoeven <s.verhoeven@esciencecenter.nl>
Co-authored-by: Bart Schilperoort <b.schilperoort@esciencecenter.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API reference in docs broken
2 participants