Fix CI, tests, docs build of the plugin-branch #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSchilperoort
commented
May 31, 2023
Peter9192
approved these changes
Jun 7, 2023
|
Kudos, SonarCloud Quality Gate passed! |
BSchilperoort
changed the title
BSchilperoort
changed the title
BSchilperoort
added a commit
that referenced
this pull request
Jun 8, 2023
…ructure (#347) * Move models to plugin folder * Move forcing and example parameter sets to plugins (and lisflood config) * Move model-specific tests to model plugin folder in tests * Move remaining tests into src folder and add ewatercycle.testing module This triggers circular import issues * fix circular import by splitting in model and models * fix test paths * Use entry points for forcings + require python >=3.10 * Not longer need typing_extensions * Add typing back * Use SomethingDownloader to download example parameter set * Refactor parameter sets * Fix CI, tests, docs build of the plugin-branch (#348) * Change python versions to strings in CI workflows * Remove conda python<3.11 pin. * Moved abstract model to base/model.py * Refactor models folder to file * Refactor forcing. Default to base, rest to forcing.py * Remove parametersetdb.ParameterSet * Move case sensitive config parser to util.py * Removed parametersetdb. Still used parts moved. * Refactored forcing sources, ewc/forcing.py. * Fix DefaultForc test, get name from __fields__ * Add type hinting to forcing sources * Fix src/ tests * Fix plugin tests * Apply linters: black, isort. * Remove python 3.11 * Fix setup-cfg-fmt issue * Fix pre-commit. Removed `setup-cfg-fmt`: incompatible w/ Py3.10 * Silence sonarcloud false positive * Add new github downloader * Fix pcrglob test, parameterset tests * Please linters * Add RTD config file * Add pydantic to docs requirements * Update conf.py and docs/requirements.txt to fix docs * Bump CI actions/checkout to v3. * pre-commit * Make SonarCloud happy * Fix docs: move to sphinx-autoapi * Make yamllint happy * Removed skipped tests from parameter_sets/test_example.py --------- Co-authored-by: sverhoeven <s.verhoeven@esciencecenter.nl> Co-authored-by: Bart Schilperoort <b.schilperoort@esciencecenter.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update docssee Update outdated docs #350Note: the following tests are still skipped (broken or superceded):