-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change InputError to KeyError #412
Conversation
Shall I also add a link to these maps with the basin_ids? https://github.com/Daafip/caravan-map |
I was also working on fixing some things yesterday, see 876efe8
Could be nice, yes. But perhaps better if you can host it on github pages. Perhaps moving it to the ewatercycle org might also be better. Also see the issue I opened Daafip/caravan-map#1 |
https://www.ewatercycle.org/caravan-map/ Done! Do you have any suggestions for the index page? |
I think if you copy part of the README there that would be good. Some explanation why the map exists (to explore and find basin IDs). And put in some relevant links to e.g. the ewatercycle documentation. |
How do I then mock the function if its a class method? |
I believe just with mock.patch. |
Ah, issue with my local unit testing and having the correct version |
f9ed563
to
aa97515
Compare
Tried to fix the test coverage but don't think a higher coverage is easily met as most of uncovered is downloading files.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor comments. Feel free to merge once these are resolved.
With the downloading writing sensible tests can be difficult. But I think this file is sufficiently covered now. The file has an 85% coverage, sonarcloud just doesn't like that some of the changed lines in this PR aren't covered (the measure is per PR, not per file...)
Quality Gate failedFailed conditions |
Missed the Bart's last comment in #407 :||, this works better if we can actually see the sonar could test