Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop extra deps #51

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Drop extra deps #51

merged 3 commits into from
Jun 27, 2023

Conversation

Kirill888
Copy link
Contributor

Hi thanks for this action it's very handy.

I started using it and noticed that installing gdebi takes a significant proportion of the overall setup. So I switched to installing apptainer with just apt-get. I have also tried to add caching, but not sure if that is actually working, as I seem to always get Downloading message.

installing gdebi takes a bit of time and apt-get supports
installation of local packages anyway

also adding caching of the deb package
@sverhoeven
Copy link
Member

Thanks for the contribution.

However the apptainer.deb has deps like squashfuse and fuse2fs that get installed by using gdebi, while apt install apptainer.deb does not. This was reported in #21 .
We could install squahsfuse and fuse2fs with apt, but that would not reduce the setup time by a lot as gdebi does not have be installed.

@Kirill888
Copy link
Contributor Author

@sverhoeven before switching to gdebi things were installed with dpkg which doesn't pull in dependencies. With this change it's installed with apt-get install which does install dependencies. Issues with gdebi is that it pulls in a bunch of GUI dependencies, so it's not just about speed of the installation but also about significantly increasing chances of various kinds of failure.

below is the log from one of the workflows using this patch:

Dowloading https://github.com/apptainer/apptainer/releases/download/v1.1.9/apptainer_1.1.9_amd64.deb
Adding deb to cache
... /opt/hostedtoolcache/apptainer/1.1.9/x64
/usr/bin/sudo apt-get install -y /opt/hostedtoolcache/apptainer/1.1.9/x64/apptainer.deb
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
  fuse2fs libfuse2 libsquashfuse0 squashfuse
The following NEW packages will be installed:
  apptainer fuse2fs libfuse2 libsquashfuse0 squashfuse
0 upgraded, 5 newly installed, 0 to remove and 27 not upgraded.

as you can see those missing dependencies are included.

@sverhoeven
Copy link
Member

Cool, indeed that is much quicker.

@sverhoeven sverhoeven merged commit 25934af into eWaterCycle:main Jun 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants