Avoid logging.basicConfig #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinvis
reviewed
Nov 10, 2022
pymech/log.py
Outdated
| handler = logging.StreamHandler() | ||
| formatter = logging.Formatter("%(levelname)s: %(message)s") | ||
| handler.setFormatter(formatter) | ||
| logger.addHandler(handler) |
There was a problem hiding this comment.
Thanks for figuring this out!
|
@paugier Can you ensure mypy passes? |
|
I don't know how to do it! I tried locally and it passes... |
|
Coverage is a bit difficult here since we would need to run without rich. |
That's alright, I dont mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66 (and snek5000/snek5000#38)
logging.basicConfigshould be used only in scripts because it affects the root logger, which can break other loggers.