Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to plugins/browsing. #25

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gspringtech
Copy link

I wanted to have Select boxes for Owner and Group - also noticed that changes to Owner and Group weren't being save.

Changed inputs to readonly: Resource, Created, Last Modified.
Changed to Select: Owner, Group (live lists of available Users and Groups are loaded from the db as needed)
Added empty item to Access Control List (to overcome problem when no ACL is present)
Modified "Save" button action so that changes to Owner, Group and Mime are now also saved.

Changed inputs to readonly: Resource, Created, Last Modified.
Changed to Select: Owner, Group (live lists of available Users and Groups are loaded from the db as needed)
Added empty item to Access Control List (to overcome problem when no ACL is present)
Modified "Save" button action so that changes to Owner, Group and Mime are now also saved.
@dizzzz dizzzz removed their assignment Oct 28, 2014
@dizzzz
Copy link
Member

dizzzz commented Oct 28, 2014

I am not sure I am the right person to review the change. maybe @windauer or @wolfgangmm or @ljo ?

it does look good, but I could not judge....

@windauer
Copy link
Member

windauer commented Feb 21, 2017

From what I see on the first view it looks good but I haven't tested it.

@adamretter
Copy link
Member

@windauer would you and @JoernT be able to test and make a decision on merging please?

@joewiz joewiz added the dashboard-1.x Specific to Dashboard 1.x label Jan 26, 2019
@joewiz
Copy link
Member

joewiz commented Jan 26, 2019

@gspringtech Thank you for this submission, and I'm sorry it wasn't acted on. Development energies have shifted to dashboard 2.0. Before I close this PR (since surely the underlying code won't work in 2.0), I believe we need to investigate whether a similar improvement is needed in 2.0 or whether it already implements this idea.

@joewiz joewiz requested review from a team and removed request for JoernT, windauer and wolfgangmm January 26, 2019 21:02
@joewiz
Copy link
Member

joewiz commented Jan 26, 2019

@eXist-db/xquery-contributors Would anyone be available to check the new dashboard to see if this idea is applicable there? If so, we should close this and start a new issue reiterating the requirements, so that the feature can be added to the new dashboard.

@line-o
Copy link
Member

line-o commented Feb 25, 2022

@joewiz This PR builds on a former version of the dashboard and is no longer applicable.
The dojo framework was dropped in favour of polymer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard-1.x Specific to Dashboard 1.x enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants