Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/datasync article #634

Merged
merged 1 commit into from Jun 11, 2021
Merged

Fix/datasync article #634

merged 1 commit into from Jun 11, 2021

Conversation

line-o
Copy link
Member

@line-o line-o commented Jun 10, 2021

One of the listings in the data sync article had two elements at its root.

With this PR applied the listing is split into two, which also makes the article a little nicer to read.

/exist/apps/doc/datasync.xml

This also fixes the error that is thrown when documentation app is installed via upload in package manager

Screenshot 2021-06-10 at 00 20 29

@line-o line-o requested a review from joewiz June 10, 2021 08:04
@line-o
Copy link
Member Author

line-o commented Jun 10, 2021

built on top of #626

@line-o
Copy link
Member Author

line-o commented Jun 10, 2021

This issue was introduced in #549

@adamretter
Copy link
Member

@line-o This needs to be rebased on HEAD I think, as at the moment it is showing a whole load of other unrelated changes

@joewiz
Copy link
Member

joewiz commented Jun 11, 2021

Rebased on HEAD.

Copy link
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@line-o Thanks! I'm not sure why mvn validate didn't raise an error before (oXygen's well-formedness check flagged it). At least we now have only well-formed XML in the repository.

@joewiz joewiz merged commit b071189 into eXist-db:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants