This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Shadow dom #9
Merged
Shadow dom #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line-o
approved these changes
Mar 26, 2019
| }) | ||
| // Pending since index pages have console error | ||
| // see https://github.com/eXist-db/monex/issues/60 | ||
| xdescribe('profiling', function () { |
There was a problem hiding this comment.
Have you tried describe.skip(...) here?
There was a problem hiding this comment.
both work the same, for consistency i stuck with x
There was a problem hiding this comment.
I still prefer .skip being more readable and more obvious. Also, it is not mentioned in the mocha docs front page and could therefore be considered discouraged style. Moreover, is there a alternative representation for .only?
So, in the long run I would prefer to switch to .skip globally.
| cy.contains('/db/apps/monex/controller.xql') | ||
| }) | ||
| }) | ||
| xdescribe('indexes', function () { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functional tests of the new and old dashboards.
old package-manager has a skipped test, fixing it seems not worth the effort. If anybody feels like having a go at it be my guest.
The 2 skipped monex test still point to actual errors
close #8 #1